Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add exclude and include tag options to update command and add logging of each test case to update command #786

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

tromai
Copy link
Member

@tromai tromai commented Jul 4, 2024

Description

Setup the dev environment and run the following command:

python ./tests/integration/run.py update ./tests/integration/cases/...
...
AttributeError: 'Namespace' object has no attribute 'include_tag'

This is because here

update_parser = command_parsers.add_parser(
name="update",
parents=[shared_arguments_parser],
help="Run test cases, but update expected output files instead of comparing them with expected output.",
)
update_parser.add_argument(
*("-m", "--macaron"),
help="The command to run Macaron. Note: can be path to the run_macaron.sh script.",
default="macaron",
)

we create option parsers for --excluded-tag and --include-tag which are necessary for the update command of Macaron later
if args.command == "update":
return do_update(
test_case_dirs=test_case_dirs,
macaron_cmd=macaron_cmd,
include_tags=args.include_tag,
exclude_tags=args.exclude_tag,
)

…logging of each test case to update command

Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
@tromai tromai added bug Something isn't working tests Enhancement of tests labels Jul 4, 2024
@tromai tromai self-assigned this Jul 4, 2024
@tromai tromai requested a review from behnazh-w as a code owner July 4, 2024 01:14
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 4, 2024
@tromai tromai merged commit 65f9e7e into staging Jul 4, 2024
11 checks passed
@tromai tromai deleted the tromai/issue-with-testing-utility-update-command branch July 4, 2024 01:50
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
…logging of each test case to update command (#786)

Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OCA Verified All contributors have signed the Oracle Contributor Agreement. tests Enhancement of tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants