[JVSC-300] Remove quoting in nbcode launch arguments #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The nbcode executable is launched from the ts/js extension using Node's
`child_process.spawn` function.
- This function directly launches the command in a new process. It does
NOT create a shell to execute it.
- Therefore, quoting the arguments passed to prevent shell splitting is
not required.
- In fact, due to the presence of extra quotes, it may lead to incorrect
splitting of arguments with spaces in them.
- This is the cause for the initialization failure of the extension
nbls when the project folder opened contains spaces in its path.
- Fixed *nbcode.ts* to remove the extra quotes added for some of the
option values.
Closes oracle#300
Signed-off-by: Siddharth Srinivasan <siddharth.srinivasan@oracle.com>
sid-srini
added a commit
to sid-srini/javavscode
that referenced
this pull request
Oct 30, 2024
…t al Backporting Netbeans PR #7908 (still under review) in order for the LSP server launch to work for launch arguments including the project path containing special characters like quotes, spaces, backticks and $. This is an interim patch to mitigate the effect on user experience, while the upstream PR is under review. It will be updated to the approved patch, as and when it is made available. This is partially related to oracle#301, which only fixes for spaces in arguments. Additionally, the same diff is applied to script/bin/nbcode which is a copy of the netbeans java.lsp.server module's copy. Signed-off-by: Siddharth Srinivasan <siddharth.srinivasan@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
child_process.spawnfunction.child_process.exec.Closes #300