Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to stabilize Jetty test #484

Merged
merged 1 commit into from
May 27, 2024
Merged

Try to stabilize Jetty test #484

merged 1 commit into from
May 27, 2024

Conversation

mhalbritter
Copy link
Collaborator

This tries to stabilize the flaky Jetty client test.

  • Finds an ephemeral free port and uses this for docker
  • uses docker publish in the form 127.0.0.1:<free port>:80
  • uses 127.0.0.1 instead of localhost

@mhalbritter mhalbritter requested a review from a team as a code owner April 16, 2024 08:26
@mhalbritter mhalbritter requested a review from dnestoro April 16, 2024 08:26
dnestoro
dnestoro approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@dnestoro dnestoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dnestoro dnestoro requested a review from fniephaus May 27, 2024 08:26
fniephaus
fniephaus approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fniephaus fniephaus merged commit 598a4d3 into oracle:master May 27, 2024
10 checks passed
@mhalbritter mhalbritter deleted the mh/try-to-fix-jetty-test branch May 27, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fniephaus fniephaus fniephaus approved these changes

@dnestoro dnestoro dnestoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhalbritter @fniephaus @dnestoro