Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Hibernate 6.2.2 #286

Merged
merged 1 commit into from
May 15, 2023

Conversation

sdeleuze
Copy link
Collaborator

This commit adds additional reflection entries for logger that are required due to https://hibernate.atlassian.net/browse/HHH-16507 and https://hibernate.atlassian.net/browse/HHH-16441 to fix compatibility with Hibernate 6.2.2.

I chose to not create a dedicated new version for maintanablity reasons and because those hints are triggered by typeReachable condition that allow to support both 6.2.0 and 6.2.2.

This commit adds additional reflection entries for logger
that are required due to
https://hibernate.atlassian.net/browse/HHH-16507 and
https://hibernate.atlassian.net/browse/HHH-16441 to fix
compatibility with Hibernate 6.2.2.
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@matthenry87
Copy link

Hi @sdeleuze,

I still had to add the below hints with 3.0.1 today to make native work (using Spring Framework 6.0.10-SNAPSHOT)

[
    {
        "name": "org.hibernate.dialect.DialectLogging_$logger",
        "methods":
        [
            {
                "name": "<init>",
                "parameterTypes":
                [
                    "org.jboss.logging.Logger"
                ]
            }
        ]
    },
    {
        "name": "org.hibernate.metamodel.mapping.MappingModelCreationLogging_$logger",
        "methods":
        [
            {
                "name": "<init>",
                "parameterTypes":
                [
                    "org.jboss.logging.Logger"
                ]
            }
        ]
    }
]

I do see hints for these in the current reachability release - but still would not work unless I added them.

@sdeleuze
Copy link
Collaborator Author

@matthenry87 I guess you did not configure 0.3.1 metadata version explicitly so 0.3.0 is used by default.

@matthenry87
Copy link

@matthenry87 I guess you did not configure 0.3.1 metadata version explicitly so 0.3.0 is used by default.

Yup you are correct, my apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants