Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for default-for attribute #275

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

sdeleuze
Copy link
Collaborator

@sdeleuze sdeleuze commented Apr 28, 2023

This new index.json attribute is design to allow more flexible version matching to avoid breakage due to switching on the latest version for untested ones.

It should have a default-for key and a regexp as a string value, for example "1\\.0\\..*" which should match versions like 1.0.0, 1.0.1, 1.0.2, etc.

See graalvm/native-build-tools#432
Closes #62

This new index.json attribute is designed to allow more
flexible version matching to avoid breakage due to
switching on the latest version for untested ones.

It should have a `default-for` key and a regexp as a
string value, for example "1\\.0\\..*" which should
match versions like 1.0.0, 1.0.1, 1.0.2, etc.

Closes oracle#62
@sdeleuze sdeleuze requested a review from a team as a code owner April 28, 2023 16:39
@sdeleuze sdeleuze requested a review from fniephaus April 28, 2023 16:39
sdeleuze added a commit to sdeleuze/native-build-tools that referenced this pull request Apr 28, 2023
This new index.json attribute is design to allow more
flexible version matching to avoid breakage due to
switch on latest version for untested ones.

It should have a `default-for` key and a regexp as a
string value, for example "1\\.0\\..*" which should
match versions like "1.0.0", "1.0.1", "1.0.2", etc.

See oracle/graalvm-reachability-metadata#62
See oracle/graalvm-reachability-metadata#275
@sdeleuze sdeleuze requested review from melix and dnestoro April 28, 2023 16:44
@dnestoro dnestoro merged commit be90554 into oracle:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a default-for attribute
2 participants