Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid printing "Alternative API option(s):" when non are present #7217

Closed

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Aug 16, 2023

Avoids output like the following:

[libjvmcicompiler:100878]  -H:ReportAnalysisForbiddenType
[libjvmcicompiler:100878]    Origin: macro option 'jvmcicompiler-library@file:///home/zakkak/code/graal/sdk/mxbuild/linux-amd64/GRAALVM_9777A156F1_JAVA21_STAGE1/graalvm-9777a156f1-java21-23.1.0-dev/lib/svm/macros/jvmcicompiler-library/@user'
[libjvmcicompiler:100878]    Alternative API option(s): 
[libjvmcicompiler:100878]  -H:Path
[libjvmcicompiler:100878]    Origin: command line

@zakkak zakkak requested a review from fniephaus August 16, 2023 13:50
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 16, 2023
@zakkak zakkak force-pushed the 2023-08-16-avoid-printing-alternative-api branch from e5a3fa2 to 0a546e6 Compare August 16, 2023 13:52
@fniephaus
Copy link
Member

Hi @zakkak, thanks for the PR. I'm already working on a number of UX fixes for the build output and this will be fixed as part of it. Essentially, we'll make the list more compact and only show one line per experimental option.

@fniephaus
Copy link
Member

Closing this in favor or #7222. Here's the relevant part: https://github.com/oracle/graal/pull/7222/files#diff-54ef73a23b10bd907d5869cc88b651fae7fef0467ccfaf8f50472cdd1e114eceR286-R303

@fniephaus fniephaus closed this Aug 17, 2023
@zakkak zakkak deleted the 2023-08-16-avoid-printing-alternative-api branch August 17, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants