[GR-46740] Support JEP 424 ("Panama") foreign down calls in Native Image. #7152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaks compatibility with JDKs < 19; this will be subsequently fixed. Add configuration parser for foreign downcalls.
Slight changes to API. Prevent foreign functions feature from being used on JDK <= 20. Improve code quality. Add copyright headers. Remove references to JDK19 (replaced by 20). Change panama configuration file layout Move classes out of PanamaAliases Fix symbol lookups behavior Replace dispatch function with a function-pointers-based solution Make downcall stubs name shorter Move all panama/foreign code in a separate module; the module is conditionally enabled if the requirements are met. Remove (almost) all references to the word "panama".
Add public API for foreign functions. Handle unsupported features more gracefully. Revert changes to python imports.
Add comment about support of shared arena. Add options to downcalls parser. Move call state capture to CFunctionEpilogue. Change exception on unregistered downcall. Change MemoryAssignment design.
Compliance.
Change (and rename) MemoryAssignment to use register objects. Change comment format, rename some things, fix code style, ... Add cost estimate to CFunctionEpilogue (when applicable). Update to JDK21. Tweak error message.
Remove the "functions" in "foreign functions". Simplify "linkToNative" substitution. Improve error message. Report unsupported features at runtime. Change 'bitAlignment' to 'byteAlignment (change from JDK 20->21). Fix alignment specifier being a postfix modifier (as opposed to a prefix modifier, as in the JDK). Simplify VMStorage resolution to register. Add runtime check for generated register allocation.
Add "--enable-native-access" to native image options
Fix partial call state capture Change call state capture infrastructure Make ABIUtils an image singleton. Fix typos. Remove occurences of the word "panama".
Stubs are now only interested in whether capture occurs or not (as opposed to interested in the precise capture set).
Disable Foreign Functions by default. Update documentation. Fix comment punctuation. Fix constant pool used for downcall stubs. Make captureCallState a boolean flag in config. Remove usage of duringAnalysis. Make assignment/type check dependent on ABI (at it should always have been). Apply miscellaneous fixes (method name, typos, ...). Fix expected call count when a pseudo C-epilogue/prologue pair is emitted. Move safety checks about capturable states to compile-time. Make descriptor parser more platform-agnostic.
…pilogue Rename dummy. Minize changes to signature files. Improve hashCode implementations. Implement linkToNative using an ImageSingleton.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support is currently limited to the AMD64 platform.