-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not load java.awt.Component and java.beans.Customizer classes when they are not used in Java Beans #5065
Closed
AlexanderScherbatiy
wants to merge
4
commits into
oracle:master
from
AlexanderScherbatiy:java-beans-customizer
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
69e3491
Do not load java.awt.Component and java.beans.Customizer classes when…
AlexanderScherbatiy ee603e4
Change the ordinary comment to a doc comment
AlexanderScherbatiy a1a4c6e
Add reachability handler for java.awt.Component class
AlexanderScherbatiy deed713
Remove unused getComponentClass() method
AlexanderScherbatiy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 81 additions & 0 deletions
81
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/JavaBeansSupport.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
/* | ||
* Copyright (c) 2022, BELLSOFT. All rights reserved. | ||
* Copyright (c) 2022, 2022, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. Oracle designates this | ||
* particular file as subject to the "Classpath" exception as provided | ||
* by Oracle in the LICENSE file that accompanied this code. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
package com.oracle.svm.core.jdk; | ||
|
||
import org.graalvm.nativeimage.ImageSingletons; | ||
import org.graalvm.nativeimage.Platform; | ||
import org.graalvm.nativeimage.Platforms; | ||
|
||
import com.oracle.svm.core.annotate.Substitute; | ||
import com.oracle.svm.core.annotate.TargetClass; | ||
|
||
import java.awt.Component; | ||
import java.beans.Customizer; | ||
import com.sun.beans.finder.ClassFinder; | ||
|
||
@SuppressWarnings({"static-method", "unused"}) | ||
public final class JavaBeansSupport { | ||
|
||
/** Remains null as long as the reachability handler has not triggered. */ | ||
private Class<?> COMPONENT_CLASS = null; | ||
|
||
// Checkstyle: stop | ||
@TargetClass(className = "java.beans.Introspector") | ||
static final class Target_java_beans_Introspector { | ||
|
||
@Substitute | ||
private static Class<?> findCustomizerClass(Class<?> type) { | ||
String name = type.getName() + "Customizer"; | ||
try { | ||
type = ClassFinder.findClass(name, type.getClassLoader()); | ||
// Each customizer should inherit java.awt.Component and implement java.beans.Customizer | ||
// according to the section 9.3 of JavaBeans specification | ||
Class<?> componentClass = lookupComponentClass(); | ||
// The Customizer does not extend java.awt.Component because | ||
// java.awt.Component class is not reachable. | ||
if (componentClass == null) { | ||
return null; | ||
} | ||
if (componentClass.isAssignableFrom(type) && Customizer.class.isAssignableFrom(type)) { | ||
return type; | ||
} | ||
} catch (Exception exception) { | ||
// ignore any exceptions | ||
} | ||
return null; | ||
} | ||
} | ||
// Checkstyle: resume | ||
|
||
private static Class<?> lookupComponentClass() { | ||
return ImageSingletons.lookup(JavaBeansSupport.class).COMPONENT_CLASS; | ||
} | ||
|
||
@Platforms(Platform.HOSTED_ONLY.class) | ||
public static void enableComponentClass() { | ||
ImageSingletons.lookup(JavaBeansSupport.class).COMPONENT_CLASS = Component.class; | ||
} | ||
} |
71 changes: 71 additions & 0 deletions
71
substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/JavaBeansFeature.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/* | ||
* Copyright (c) 2022, BELLSOFT. All rights reserved. | ||
* Copyright (c) 2022, 2022, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. Oracle designates this | ||
* particular file as subject to the "Classpath" exception as provided | ||
* by Oracle in the LICENSE file that accompanied this code. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
package com.oracle.svm.hosted; | ||
|
||
import org.graalvm.nativeimage.ImageSingletons; | ||
import org.graalvm.nativeimage.Platform; | ||
import org.graalvm.nativeimage.Platforms; | ||
|
||
import com.oracle.svm.core.jdk.JavaBeansSupport; | ||
import com.oracle.svm.core.feature.InternalFeature; | ||
import com.oracle.svm.core.feature.AutomaticallyRegisteredFeature; | ||
import com.oracle.svm.hosted.FeatureImpl.DuringAnalysisAccessImpl; | ||
import com.oracle.svm.hosted.FeatureImpl.DuringSetupAccessImpl; | ||
|
||
import java.beans.Introspector; | ||
import java.lang.reflect.Field; | ||
|
||
@AutomaticallyRegisteredFeature | ||
final class JavaBeansFeature implements InternalFeature { | ||
|
||
private Field componentClassField; | ||
|
||
@Override | ||
public void afterRegistration(AfterRegistrationAccess access) { | ||
ImageSingletons.add(JavaBeansSupport.class, new JavaBeansSupport()); | ||
} | ||
|
||
@Override | ||
public void duringSetup(DuringSetupAccess a) { | ||
DuringSetupAccessImpl access = (DuringSetupAccessImpl) a; | ||
componentClassField = access.findField(JavaBeansSupport.class, "COMPONENT_CLASS"); | ||
} | ||
|
||
@Override | ||
public void beforeAnalysis(BeforeAnalysisAccess access) { | ||
access.registerReachabilityHandler(this::enableComponentClass, access.findClassByName("java.awt.Component")); | ||
} | ||
|
||
@Platforms(Platform.HOSTED_ONLY.class) | ||
void enableComponentClass(DuringAnalysisAccess a) { | ||
DuringAnalysisAccessImpl access = (DuringAnalysisAccessImpl) a; | ||
JavaBeansSupport.enableComponentClass(); | ||
access.rescanField(ImageSingletons.lookup(JavaBeansSupport.class), componentClassField); | ||
if (!access.concurrentReachabilityHandlers()) { | ||
access.requireAnalysisIteration(); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christianwimmer do we have a ticket for the analysis imprecision related to
<clinit>
? I think we should link it here so we delete this once the analysis imprecision is fixed.