[GR-36719] Automatically register the Sasl provider. #4279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakkak
approved these changes
Feb 1, 2022
|
@gradinac it looks like this one slipped through the cracks :) |
185db19 to
4e55e6e
Compare
|
@zakkak thank you for looking into this one! :) It had been gathering dust for a bit, I've rebased it and added internal tests, I'll look into merging it to master now :) |
7fbd490 to
15ba587
Compare
15ba587 to
a7cb207
Compare
|
I have the probleme of build native Do you know how to solve this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sasl service does not conform to the JCA and therefor is not automatically registered by our SecurityServicesFeature. This service uses
SaslClient#createSaslClientandSaslServer#createSaslServermethods as a means of instantiating different implementations of the service. However, we cannot use these methods directly for reachability handlers, as the Sasl service is used through a facade class:javax.security.sasl.SaslThis PR adds the special handling required to automatically register the Sasl provider when used through
javax.security.sasl.Sasl