Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 284: Include faulty expression in compilation exception for mul… #488

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

WilliamParker
Copy link
Collaborator

…ti-child negations

@k13gomez
Copy link
Contributor

Nice, I'm also planning to start a backlog of linter enhancements and add support to catch many of these issues there, instead of at run/compile time.

@WilliamParker
Copy link
Collaborator Author

@k13gomez Yes, it would be nice to have this in clj-kondo too, as you say it would catch errors earlier. However that won't cover cases where Clara is used as a compilation target, for example in more targeted industry-specific DSLs, so this is still useful I think. I wasn't actually setting out to improve errors specifically though, I was just starting at the beginning of the issue list and working forward to see what we can close and this looked easy to just implement.

@k13gomez
Copy link
Contributor

This looks good, I can merge it and include in next release; do you want to add an entry to the change log?

@WilliamParker WilliamParker merged commit a22cba9 into oracle-samples:main Jun 20, 2023
@WilliamParker
Copy link
Collaborator Author

Merged with a changelog entry, all done for you to release at your convenience @k13gomez .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants