feat: automate clojars releases for release tags with travis-ci #474
Conversation
|
|
| ["clojars" {:url "https://repo.clojars.org" | ||
| :username :env/clojars_username | ||
| :password :env/clojars_password | ||
| :sign-releases false}]]) |
There was a problem hiding this comment.
I suppose this isn't completely ideal, but since we (at least I) haven't published the GPG key I used to manually deploy in reality it isn't much different from what we've done before. Also in practice it would be quite obvious if releases that didn't have a corresponding tag were created and since nobody has ever asked about signature on the jars I'm guessing it isn't checked. So basically I think this is OK.
There was a problem hiding this comment.
I thought this would be fine as well, if someone has an issue with jar signing in the future we can open a new issue and find a way to get GPG working on the CI environment but I don't think that will be the case.
| :creds :gpg}]]) | ||
| :creds :gpg}] | ||
| ["clojars" {:url "https://repo.clojars.org" | ||
| :username :env/clojars_username |
There was a problem hiding this comment.
From some quick googling it looks like we'll need these variables to be added using the instructions at https://docs.travis-ci.com/user/environment-variables/#encrypting-environment-variables. Is that what you're thinking? I could have missed something of course, I haven't looked at the travis docs in much depth to be honest.
There was a problem hiding this comment.
@WilliamParker yes, I have already added the variables from the build configuration in Travis CI console
|
@mrrodriguez @EthanEChristian do you have any concerns? Think we can get this approved/merged to start doing releases more easily? |
Discussed in #473