ISSUE-393: Fix incorrect equality semantics when unifying similar obj… #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrrodriguez
approved these changes
Jun 22, 2018
|
|
||
| Object | ||
| (equals [this other] | ||
| (= wrapped (.wrapped ^JavaEqualityWrapper other))) |
There was a problem hiding this comment.
You are assuming the other is always going to be a JavaEqualityWrapper, otherwise there could be cast exceptions. I believe that is fine though, since this is only intended to be used/compared in collections that contain only these JavaEqualityWrapper wrapper types.
To confirm: this is your reasoning here, correct?
There was a problem hiding this comment.
That is the only use case I had in mind, but it's a good idea to add an instance? check here. They're quite cheap and makes this class more general.
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #393 by simply wrapping potential keys in a Java object that explicitly uses Clojure's equality and hash logic.