Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enh] Displays page list according to the sort order preferences applied to pages. #4928

Closed
wants to merge 4 commits into from

Conversation

W6HBR
Copy link
Contributor

@W6HBR W6HBR commented Dec 18, 2024

Updates \Admin\Pages Add, Edit & Index to display pages according to the sort order preferences applied to pages.

Displays page list according to the sort order preferences applied to pages.
Displays page list according to the sort order preferences applied to pages.
Displays page list according to the sort order preferences applied to pages.
Adds Description column to the index display.  Installations with many roles can benefit from seeing the detailed description in addition to the role name.
@W6HBR
Copy link
Contributor Author

W6HBR commented Dec 18, 2024

FYI - the last file here was supposed to be a separate pull request - Oqtane.Client\Modules\Admin\Roles\Index.razor.
(I didn't realize it would add in to the previous pull request for the Page Mgmt updates.)

@sbwalker
Copy link
Member

sbwalker commented Dec 19, 2024

@W6HBR the issue with the sort order for Pages was caused by PR #4412. Prior to this optimization, various components were relying on the PageState.Pages collection. However the PageState properties had to be optimized for performance reasons in Static Blazor which meant that module components needed to load the Pages collection from the PageService rather than relying on PageState.Pages. The PageService GetPages method does not return the list of pages in the same order as the PageState.Pages collection. This difference in behavior is what caused the issue with sort order in Page Management. I am going to close this PR as the better way to resolve this problem is included in #4931.

@sbwalker sbwalker closed this Dec 19, 2024
@W6HBR
Copy link
Contributor Author

W6HBR commented Dec 19, 2024

Copy that... thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants