-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added web.Release.config to include remove WebDAV during the publish stage of a release #1957
Conversation
…stage of a release
Code cleanup. I removed the unnecessary comments. This code will remove WebDAV during the publish stage of a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the unnecessary comments.
@Rodien I was doing some local upgrade testing and when I installed version 3.0.3 which contains the WebDAV changes, my local IIS threw an exception and would not start the app: This configuration section cannot be used at this path. This happens when the section is locked at a parent level. Locking is either by default (overrideModeDefault="Deny"), or set explicitly by a location tag with overrideMode="Deny" or the legacy allowOverride="false".
I never had problems installing Oqtane on IIS in the past - so it appears that the WebDAV modification caused this issue. My concern is that other people will experience this issue as well when trying to install Oqtane. So I am not sure if this modification should be rolled back? Looping in @leigh-pointer as well since he has helped many people with WedDAV issues. |
I have not been able to reproduce this… What I did =>
My System:
Maybe double check your "Internet Information Services" configuration. |
@leigh-pointer yes I unzipped the Oqtane.Framework.3.0.3.Install.zip file into a clean folder and it contained the web.config file (with the WebDAVModule removal logic):
IIS threw an error when I tried to start the app in a browser - so I removed the
and the error went away and the app started up. |
@Rodien you may be correct that it is related to my IIS configuration. The strange thing is that Oqtane functions just fine with my IIS configuration - however the WebDAVModule removal item in web.config throws an exception, so I had to remove it manually. |
I am kind of interested to know how you are able to run oqtane without turning on ASP.NET 4.8. Try turning ASP.NET 4.8 on. And this is an installation without the But the moment I turn ASP.NET 4.8 on oqtane starts working again. I'm using "" in many DNN installations and have never had issues with it. |
@Rodien oqtane run on .netcore and not asp.net |
@leigh-pointer Yes, I know that Oqtane runs on .NetCore but Oqtane does not work when I turn ASP.NET 4.8 off. |
Take a look at NopCommerce they are also making use of |
Adding the Remove WebDav logic to webconfig at build was supposed to help developers and automate things. But if it's getting in the way then I agree with @leigh-pointer that it should be removed. |
…et core environments (see oqtane#1957)
remove web.release.config as it causes installation issues in pure .net core environments (see #1957)
removed in #2140 - @Rodien I really appreciate your efforts to try and help streamline the installation process... unfortunately it seems that there are some variables which impact its effectiveness. Thank you @leigh-pointer for the insights into pure .NET Core environments vs. .NET Framework environments. |
Transformations to the web.config file can be applied automatically when an app is published based on Build configuration.
I decided to make this pull request after reading the following discussion: #1952