Settings for ModuleDefinitions #1829 #1832
Conversation
Add Update settings for the ModuleDefinition
|
@leigh-pointer after reviewing this I just realized that there may an issue. ModuleDefinitions are stored in the Master database (ie. MasterDBContext) whereas Settings are stored in each Tenant database (ie. TenantDBContext). This PR may appear to work on a default install however as soon as you create another site using its own database you will realize that the settings are not shared across tenants - which essentially breaks your original goal. This is the reason why the SettingService API does not currently have Host Settings - it only has Tenant Settings. In order to implement this feature would require more work. |
|
Ok understand but for me i see it as moddef is set when the mod is first used, therefore if in a new tenant the mod is not used there is no reason to know about thes setup data! Or am I losing the plot!
Are all moduledefs stored in the master? If so, then i agree.
|
|
ModuleDefinitions are stored only in the Master - they are global to the installation |
|
Ok then it would be good to master something tenant related, or does that break the overall plan?
…________________________________
From: Shaun Walker ***@***.***>
Sent: Wednesday, November 24, 2021 7:29:19 PM
To: oqtane/oqtane.framework ***@***.***>
Cc: Leigh Pointer ***@***.***>; Mention ***@***.***>
Subject: Re: [oqtane/oqtane.framework] Settings for ModuleDefinitions #1829 (PR #1832)
ModuleDefinitions are stored only in the Master - they are global to the installation
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1832 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACICRPFK6QVIYRO3RG7KPILUNUVH7ANCNFSM5IWJX7NQ>.
|
|
I have a simple solution for now. I will use the Get/UpdateSiteSettings then I can store the settings when the table is created the firsts time and then the settings are in the correct Tenant. |
|
I think this enhancement is valuable and I believe I have a solution... so I will merge your PR and make the necessary adjustments |
Add Update settings for the ModuleDefinition