Remove admin border after edit #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After finish Edit, there's a class "container" which is conflict with Bootstrap that cause an issue on Full-width pane.
|
|
|
Could you please share a GIF to see the UI issue on action? |
|
This behavior is by design. If you want to change the default user experience you should override the CSS class in your theme - not modify core code. |
|
|
|
Indeed, we can just overwrite the CSS. |
|
I will have to take a closer look at this as I am concerned that this change will have an adverse effect on themes which do not use full-width panes. |
|
After further testing I think your fix is in fact the correct solution. Thank you for sharing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After finish Edit, there's a class "container" which is conflict with Bootstrap that cause an issue on Full-width pane.