Cross-OS build/deployment #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1a3d12 to
ec5873b
Compare
hamidelmaazouz
approved these changes
Mar 4, 2024
.github/workflows/deploy-wheels.yaml
Outdated
| # export PATH="/root/.cargo/bin:${PATH}" | ||
| # export PATH="/root/.local/bin:$PATH" | ||
| # cd src/munchkin | ||
| # MK_DOWNLOAD_LLVM=true pwsh ./build.ps1 |
There was a problem hiding this comment.
I think it's about time we enable the cache back, only reason why it didn't get through in BB was cache size limitation ... 🤔
There was a problem hiding this comment.
not sure how GH workflow is, would it run a builds as per the defined matix support here ?
I mean how do you test each of these build types ?
There was a problem hiding this comment.
It runs in the various OS images, all the linux ones run, the winedows one didn't run (but I made modifications locally so now should run), Mac one will likely be untested.
ec5873b to
ca683db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.