Allow generating SSH keys for users #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing values to 0 or empty string can be simplified by making the parameters optional and defaulting their values to undef. undef evaluates to false, making conditionals more straightforward.
When no passphrase is provided, just don't pass it to ssh-keygen(1). While here, add a test to check when a passphrase is passed.
|
This looks good. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ssh::keygendefined type allows to generate keys for the root user. At $WORK, we extended the module to allow generating keys for random users, and think this could be upstreamed.I included some minor refactoring we did internally to this PR. Let me know if you do not like these enhancements and I'll update accordingly.