Allow managing ssh_config(5) configuration file #41
Conversation
This is heavily based on the code to manage the `sshd_config(5)` configuration file. For consistency, it does not enforce types for the configuration parameters. Some basic testing has been setup, but since it implies a lot of duplication, ssh::client::host and ssh::client::match defined types are not tested for now.
|
Excellent. Without validating the configuration options too close, this looks good. Thanks for the efforts. As for the config types, that certainly would be nice since pretty much everything is a string. When I started the module, I parsed the man page for all the keywords can called it good. I'm open to change for sure, but also not too worried about it. I'd been using the latest manpage from openbsd to give me the options for config and review each time there is a release. That said, I know there were some client options I'd skipped since it wasn't implemented here. Thanks again @smortex. Good to hear from you again. |
|
Cool, so let's keep this that way for now: I don't think it will be a lot of work for maintenance, and if it becomes, we could address this with some refactoring to reduce duplication later (and then if there is no duplication, it may make sense to look into validating parameter types) 😄 . The client configuration happens to be handy for syncing clients and servers configurations in profiles (e.g. SendEnv and AcceptEnv). |
This is heavily based on the code to manage the
sshd_config(5)configuration file. For consistency, it does not enforce types for the configuration parameters.Some basic testing has been setup, but since it implies a lot of duplication, ssh::client::host and ssh::client::match defined types are not tested for now.
I guess some duplication could be removed but I could not find a way to do so without the client and server being configured in fundamentally different ways, which would be unexpected. While a global refactoring might make sense, it's a huge task, and I would not want to start going in this direction if you do not second this 😉