Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to use java 1.7 #208

Merged
merged 3 commits into from
Aug 23, 2018
Merged

update to use java 1.7 #208

merged 3 commits into from
Aug 23, 2018

Conversation

thomaszurkan-optimizely
Copy link
Contributor

No description provided.

mikeproeng37
mikeproeng37 suggested changes Aug 22, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we don't do this yet in other SDKs, but I think it'd be a good idea to mention in our README that we only support Java 7+

@coveralls
Copy link

coveralls commented Aug 22, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 588

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.41%
Totals Coverage Status
Change from base Build 586: 0.0%
Covered Lines: 2347
Relevant Lines: 2625
💛 - Coveralls

@thomaszurkan-optimizely
Copy link
Contributor Author

good call

mikeproeng37
mikeproeng37 approved these changes Aug 22, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@wangjoshuah wangjoshuah mentioned this pull request Aug 22, 2018
Merged
@shihpatrick shihpatrick merged commit 1275c9c into master Aug 23, 2018
@wangjoshuah
Copy link
Contributor

@thomaszurkan-optimizely, you can probably drop java 7 Jan 16th 2019.
https://cloud.google.com/appengine/docs/deprecations/java7

@mikeproeng37 mikeproeng37 deleted the upgrade/java/1.7 branch September 21, 2018 22:35
@thomaszurkan-optimizely thomaszurkan-optimizely mentioned this pull request Oct 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thomaszurkan-optimizely @coveralls @wangjoshuah @mikeproeng37 @shihpatrick