Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelisted bucketing logic is in DecisionService #98

Merged
merged 2 commits into from
Aug 21, 2018
Merged

Whitelisted bucketing logic is in DecisionService #98

merged 2 commits into from
Aug 21, 2018

Conversation

msohailhussain
Copy link
Contributor

We are checking whitelisted users in decision service, get variation method. This logic was placed when DecisionService class didn't exist.

@msohailhussain msohailhussain requested review from mikeproeng37 and a team August 21, 2018 16:37
mikeproeng37
mikeproeng37 approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, compat tests for this case pass locally for me.

@mikeproeng37
Copy link
Contributor

build

@mikeproeng37
Copy link
Contributor

build-e2e

@mikeproeng37 mikeproeng37 merged commit 7ba5a66 into master Aug 21, 2018
@msohailhussain msohailhussain deleted the sohail/whitelisteduserissue branch January 31, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msohailhussain @mikeproeng37