Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Duplicate experiment key issue with multi feature flag #267

Merged
merged 7 commits into from
Jul 15, 2021
Merged

feat: Duplicate experiment key issue with multi feature flag #267

merged 7 commits into from
Jul 15, 2021

Conversation

msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented Jul 8, 2021 •
edited
Loading

Summary

  • Fixed an issue related to duplicate experimentKey.
  • While trying to get variation from the variationkeyMap, it was unable to find because the latest experimentKey was overriding the previous one.

TestPlan

msohailhussain and others added 2 commits July 8, 2021 16:59
@msohailhussain
fixed an issue.
2ca466b
@mnoman09
Fixed comments
257ac82 
Minor change of  group experiment stored using key are now stored using id as map key.
@msohailhussain msohailhussain marked this pull request as ready for review July 9, 2021 16:54
@msohailhussain msohailhussain requested a review from a team as a code owner July 9, 2021 16:54
@msohailhussain msohailhussain changed the title TESTING - Unique experiment key feat: Duplicate experiment key issue with multi feature flag Jul 9, 2021
keppel2
keppel2 approved these changes Jul 9, 2021
View reviewed changes
OptimizelySDK/ProjectConfig.cs
@@ -227,6 +236,15 @@ public interface ProjectConfig
/// entity if key or ID is invalid</returns>
Variation GetVariationFromId(string experimentKey, string variationId);

/// <summary>
/// Get the Variation from the Key/ID
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"key" and "id" have different capitalization in the various comments.

Mat001
Mat001 approved these changes Jul 9, 2021
View reviewed changes
Copy link

@Mat001 Mat001 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No unit tests needed? @msohailhussain

@msohailhussain
Copy link
Contributor Author

No unit tests needed? @msohailhussain

good point, yes we need to add unit tests but I think I can add a separate ticket. Need to think about some scenarios.

@msohailhussain msohailhussain removed their assignment Jul 12, 2021
jaeopt
jaeopt requested changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix errors

jaeopt
jaeopt approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustin-sier dustin-sier requested review from dustin-sier and removed request for dustin-sier July 13, 2021 17:33
@jaeopt jaeopt merged commit 304ebc4 into master Jul 15, 2021
@jaeopt jaeopt deleted the sohail/uniqueexperimentkey branch July 15, 2021 16:56
msohailhussain added a commit that referenced this pull request Jul 16, 2021
@msohailhussain
feat: Duplicate experiment key issue with multi feature flag (#267)
a8a796b
msohailhussain added a commit that referenced this pull request Jul 16, 2021
@msohailhussain
Preparing v3.9.1 (#269)
8814b67 
* feat: Duplicate experiment key issue with multi feature flag (#267)

* chore: preparing 3.9.1 release (#268)

* dlls generation for v3.9.x branch

updating branch so proper dlls are generated for this release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@keppel2 keppel2 keppel2 approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@msohailhussain msohailhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msohailhussain @Mat001 @keppel2 @jaeopt @mnoman09