Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nuget added configuration manager dependency for .netstandard 2.0 #262

Merged
merged 1 commit into from
Mar 25, 2021
Merged

fix: nuget added configuration manager dependency for .netstandard 2.0 #262

merged 1 commit into from
Mar 25, 2021

Conversation

msohailhussain
Copy link
Contributor

Summary

  • System.Configuration.ConfigurationManager dependency was missing in nuget package.
  • licenseUrl is deprecated, updated to license element.
  • IconUrl is deprecated, updated to Icon

Test plan

  • All unit tests must pass
  • Manual testing, generated nuget package and tested
  • FSC must pass.

@msohailhussain msohailhussain marked this pull request as ready for review March 25, 2021 15:37
@msohailhussain msohailhussain requested a review from a team as a code owner March 25, 2021 15:37
jaeopt
jaeopt approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit 6b05036 into master Mar 25, 2021
@jaeopt jaeopt deleted the sohail/nufix branch March 25, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@msohailhussain msohailhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msohailhussain @jaeopt