Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: SendImpressionEvent will return false when event is not sent #257

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Fix: SendImpressionEvent will return false when event is not sent #257

merged 2 commits into from
Jan 28, 2021

Conversation

mnoman09
Copy link
Contributor

Summary

  • SendImpressionEvent will return false when event is not sent and return true when sent successfully
  • In case of userEvent is null it will return false

@mnoman09 mnoman09 requested a review from a team as a code owner January 27, 2021 17:32
@msohailhussain msohailhussain requested a review from jaeopt January 27, 2021 19:00
jaeopt
jaeopt requested changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can we add unit tests to catch the error?

jaeopt
jaeopt approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - more unit tests will be in a separate PR

@jaeopt jaeopt merged commit 53474fb into master Jan 28, 2021
@jaeopt jaeopt deleted the mnoman/decideDispatchedEventFix branch January 28, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @jaeopt @msohailhussain