feat: return reasons and remove from args. #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w and added TODO above to come up with logic of setting it using decide option Fixed unit tests and resolved minor null pointer exceptions
msohailhussain
commented
Dec 29, 2020
|
|
||
| } | ||
|
|
||
| // success! | ||
| variation = config.GetVariationFromId(experiment.Key, variationId); | ||
| message = $"User [{userId}] is in variation [{variation.Key}] of experiment [{experiment.Key}]."; | ||
| Logger.Log(LogLevel.INFO, reasons.AddInfo(message)); | ||
| return variation; | ||
| return Result<Variation>.NewResult(variation, reasons); |
| if (!ExperimentUtils.IsExperimentActive(experiment, Logger)) return null; | ||
|
|
||
| // check if a forced variation is set | ||
| var forcedVariation = GetForcedVariation(experiment.Key, userId, config, reasons); | ||
| var forcedVariation = GetForcedVariation(experiment.Key, userId, config); |
There was a problem hiding this comment.
call it forcedVariationResult
| if (forcedVariation != null) | ||
| return forcedVariation; | ||
| { | ||
| reasons += forcedVariation?.DecisionReasons; |
There was a problem hiding this comment.
append before if condition.
| if (!ExperimentUtils.IsExperimentActive(experiment, Logger)) return null; | ||
|
|
||
| // check if a forced variation is set | ||
| var forcedVariation = GetForcedVariation(experiment.Key, userId, config, reasons); | ||
| var forcedVariation = GetForcedVariation(experiment.Key, userId, config); | ||
| if (forcedVariation != null) |
There was a problem hiding this comment.
must check result object.
| @@ -558,9 +554,9 @@ public void SaveVariation(Experiment experiment, Variation variation, UserProfil | |||
| /// <param name = "filteredAttributes" >The user's attributes. This should be filtered to just attributes in the Datafile.</param> | |||
| /// <returns>null if the user is not bucketed into any variation or the FeatureDecision entity if the user is | |||
| /// successfully bucketed.</returns> | |||
| public virtual FeatureDecision GetVariationForFeature(FeatureFlag featureFlag, string userId, ProjectConfig config, UserAttributes filteredAttributes) | |||
| public virtual Result<FeatureDecision> GetVariationForFeature(FeatureFlag featureFlag, string userId, ProjectConfig config, UserAttributes filteredAttributes) | |||
There was a problem hiding this comment.
I think we should remove this method. No use of it.
jaeopt
requested changes
Jan 4, 2021
| LoggerMock.Verify(l => l.Log(LogLevel.ERROR, | ||
| string.Format("Variation \"{0}\" is not in the datafile. Not activating user \"{1}\".", invalidVariationKey, userId)), | ||
| Times.Once); | ||
|
|
||
| BucketerMock.Verify(_ => _.Bucket(It.IsAny<ProjectConfig>(), It.IsAny<Experiment>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<IDecisionReasons>()), Times.Never); | ||
| BucketerMock.Verify(_ => _.Bucket(It.IsAny<ProjectConfig>(), It.IsAny<Experiment>(), It.IsAny<string>(), It.IsAny<string>()), Times.Never); |
There was a problem hiding this comment.
Need to validate reasons messages as well
Removed unnecessary ? marks
jaeopt
approved these changes
Jan 7, 2021
| @@ -461,20 +461,15 @@ public void SaveVariation(Experiment experiment, Variation variation, UserProfil | |||
| if (userMeetConditionsResult.ResultObject) | |||
| { | |||
| variationResult = Bucketer.Bucket(config, rolloutRule, bucketingIdResult.ResultObject, userId); | |||
|
|
|||
| reasons += variationResult?.DecisionReasons; | |||
There was a problem hiding this comment.
Suggested change
| reasons += variationResult?.DecisionReasons; | |
| reasons += variationResult.DecisionReasons; |
| @@ -486,9 +481,10 @@ public void SaveVariation(Experiment experiment, Variation variation, UserProfil | |||
| if (userMeetConditionsResultEveryoneElse.ResultObject) | |||
| { | |||
| variationResult = Bucketer.Bucket(config, everyoneElseRolloutRule, bucketingIdResult.ResultObject, userId); | |||
| reasons += variationResult?.DecisionReasons; | |||
There was a problem hiding this comment.
Suggested change
| reasons += variationResult?.DecisionReasons; | |
| reasons += variationResult.DecisionReasons; |
# Conflicts: # OptimizelySDK.Tests/BucketerTest.cs # OptimizelySDK.Tests/UtilsTests/ExperimentUtilsTest.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan