feat: Add datafile accessor #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,6 +77,11 @@ public enum OPTLYSDKVersion | |||
| /// </summary> | |||
| public bool? BotFiltering { get; set; } | |||
|
|
|||
| /// <summary> | |||
There was a problem hiding this comment.
header update? 2020
| /// <summary> | ||
| /// Raw datafile | ||
| /// </summary> | ||
| public string Datafile { get; set; } |
There was a problem hiding this comment.
abstract properties can not have private accessors.
msohailhussain
suggested changes
Aug 21, 2020
| @@ -14,6 +14,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| using Newtonsoft.Json; | |||
There was a problem hiding this comment.
This doesn't seem to be used
| ///Returns the datafile corresponding to ProjectConfig | ||
| /// </summary> | ||
| /// <returns>the datafile string corresponding to ProjectConfig</returns> | ||
| public string ToDatafile() |
There was a problem hiding this comment.
This isn't used. Any reason to keep it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://travis-ci.com/github/optimizely/fullstack-sdk-compatibility-suite/jobs/377668178