Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gzip): Adding gzip support for framework 4.5 or above. #218

Merged
merged 3 commits into from
May 31, 2020
Merged

feat(gzip): Adding gzip support for framework 4.5 or above. #218

merged 3 commits into from
May 31, 2020

Conversation

msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented May 22, 2020 •
edited
Loading

Summary

  • Added gzip support for downloading datafile.

Test plan

@msohailhussain msohailhussain requested a review from a team as a code owner May 22, 2020 19:26
@msohailhussain msohailhussain removed their assignment May 22, 2020
mikeproeng37
mikeproeng37 approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please link the passing FSC test and we can merge it in.

mikeproeng37
mikeproeng37 approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 49925e9 into master May 31, 2020
@mikeproeng37 mikeproeng37 deleted the sohail/gzip branch May 31, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msohailhussain @mikeproeng37