feat: Added GetAllFeatureVariables API and NotificationListener support #217
Conversation
# Conflicts: # OptimizelySDK.Tests/OptimizelyJsonTest.cs
| @@ -1789,6 +1789,9 @@ public void TestUnsupportedVariableType() | |||
| var featureVariableStringRandomType = Optimizely.GetFeatureVariableString("", "any_key", TestUserId); | |||
| Assert.IsNull(featureVariableStringRandomType); | |||
|
|
|||
| var featureVariableStringJsonType = Optimizely.GetFeatureVariableString("unsupported_variabletype", "string_json_key", TestUserId); | |||
There was a problem hiding this comment.
what's the point to add test here?
There was a problem hiding this comment.
It was an old test which was testing that getFeatureVariableString will return string value even when given json as subtype but this is no longer the case here. So now if the sub type is JSON and we will call getFeatureVariableString to get that variable, it will return null because type will not be matched.
|
|
||
| var optly = Helper.CreatePrivateOptimizely(); | ||
|
|
||
| optly.SetFieldOrProperty("ProjectConfigManager", ConfigManager); |
There was a problem hiding this comment.
I don't know why we are using reflection to instantiate optimizely instance. please explain
There was a problem hiding this comment.
this is to set decisionservice object to decisionserviceMock object.
| var result = (OptimizelyJson)optly.Invoke("GetAllFeatureVariables", null, TestUserId, userAttributes); | ||
| Assert.Null(result); | ||
|
|
||
| LoggerMock.Verify(log => log.Log(LogLevel.WARN, "The featureKey parameter must be nonnull."), Times.Once); |
There was a problem hiding this comment.
nonnull or not-null @pawels-optimizely need suggestion.
|
|
||
| var featureFlag = Config.GetFeatureFlagFromKey(featureKey); | ||
|
|
||
| var decision = new FeatureDecision(experiment, null, FeatureDecision.DECISION_SOURCE_ROLLOUT); |
There was a problem hiding this comment.
Why variation is null.
There was a problem hiding this comment.
To verify info log that ""User "" + TestUserId + "" was not bucketed into any variation for feature flag "" + featureKey + "". The default values are being returned.""
|
|
||
| DecisionServiceMock.Setup(ds => ds.GetVariationForFeature(featureFlag, TestUserId, Config, userAttributes)).Returns(decision); | ||
|
|
||
| var optly = Helper.CreatePrivateOptimizely(); |
| } | ||
|
|
||
| [Test] | ||
| public void TestGetAllFeatureVariablesValid() |
There was a problem hiding this comment.
What does it mean valid?
| @@ -1788,7 +1788,7 @@ public void TestUnsupportedVariableType() | |||
| { | |||
| var featureVariableStringRandomType = Optimizely.GetFeatureVariableString("", "any_key", TestUserId); | |||
| Assert.IsNull(featureVariableStringRandomType); | |||
|
|
|||
|
|
||
| var optly = Helper.CreatePrivateOptimizely(); | ||
|
|
||
| optly.SetFieldOrProperty("ProjectConfigManager", ConfigManager); |
Summary
Test Plan