Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blockingtimeout): Blocking timeout was not being assigned #202

Merged
merged 3 commits into from
Oct 29, 2019

Conversation

msohailhussain
Copy link
Contributor

Summary

When not providing any value, it was just logging not setting up periodinterval and blocking timeout value.

Test plan

Added unit tests.

@msohailhussain msohailhussain changed the title fix(blockingtimeout): Blocking timeout was not being assigned - WIP fix(blockingtimeout): Blocking timeout was not being assigned Oct 28, 2019
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit ba381e7 into master Oct 29, 2019
@mikeproeng37 mikeproeng37 deleted the sohail/blockingtimeoutfix branch October 29, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants