feat(api): Accepting all types for attributes values #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -458,6 +458,39 @@ public void TestActivateExperimentNotRunning() | |||
|
|
|||
| Assert.IsNull(variationkey); | |||
| } | |||
|
|
|||
| [Test] | |||
| public void TestActivateWithTypedAttributes() | |||
There was a problem hiding this comment.
This test case is not verifying the payload generated from EventBuilder is returned correctly or not.
Create an expectedEventBuilder class and call EventBuilder, and compare it.
There was a problem hiding this comment.
Added payload comparison test case for typed attributes in EventBuilderTest.cs.
| @@ -71,7 +71,7 @@ public bool Evaluate(JToken conditions, UserAttributes userAttributes) | |||
|
|
|||
| string conditionName = conditions["name"].ToString(); | |||
| return userAttributes != null && userAttributes.ContainsKey(conditionName) | |||
| && userAttributes[conditionName] == conditions["value"].ToString(); | |||
| && userAttributes[conditionName].ToString() == conditions["value"].ToString(); | |||
There was a problem hiding this comment.
This may cause some problem when any value other than string is converted into string. @oakbani
mikeproeng37
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.