-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(track): Send decisions for all experiments using an event when using track #100
Conversation
build |
@@ -0,0 +1,186 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is very specific to this scenario. Instead, I can see us potentially using this same datafile for more sophisticated tests. Let's call the datafile simple_ab_experiments
(later we can have one called feature_experiments
.
In the datafile itself, we should call the event --> event_with_multiple_running_experiments
The experiment themselves can be named more descriptively like:
running_experiment_1
running_experiment_2
This makes it easier for us to reuse some of the entities in this test datafile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mfahadahmed please delete this one as it is not used anymore.
@@ -0,0 +1,186 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mfahadahmed please delete this one as it is not used anymore.
snapshot[Params.DECISIONS] = decisions; | ||
snapshot[Params.EVENTS] = new object[]{ | ||
eventDict | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the indentation of this seems wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fix(track): Send decisions for all experiments using an event when using track.