fix(EventRescheduler): catch exception for event service restart #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnoman09
approved these changes
Feb 2, 2023
| * See the License for the specific language governing permissions and * | ||
| * limitations under the License. * | ||
| ***************************************************************************/ | ||
| // Copyright 2016,2021,2023, Optimizely, Inc. and contributors |
There was a problem hiding this comment.
Can we revert this change and just add 2023
There was a problem hiding this comment.
@mnoman09 I have been changing the copyright format to open-ended (//...) gradually.
A good point. We'll keep following on this issue. |
mnoman09
pushed a commit
that referenced
this pull request
Mar 10, 2023
mnoman09
pushed a commit
that referenced
this pull request
Mar 10, 2023
(cherry picked from commit 585f099)
mnoman09
added a commit
that referenced
this pull request
Mar 16, 2023
* fix(EventRescheduler): catch exception for event service restart (#446) (cherry picked from commit 585f099) * [FSSDK-8952] doc: Full Stack to Feature Experimentation Rename (#450) * [FSSDK-8952] doc: Full Stack to Feature Experimentation Rename --------- Co-authored-by: mnoman09 <m.nomanshoaib09@gmail.com> (cherry picked from commit 390c464) * changed java version to 3.10.3 * [FSSDK-8952] chore: prepare for release 3.13.4 (#452) * chore: prepare for release 3.13.4 * set java core version to 3.10.3 * removed comment * Revert "removed comment" This reverts commit a326808. * Revert "set java core version to 3.10.3" This reverts commit fe586f6. --------- (cherry picked from commit cbcdd1e) --------- Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rare exceptions (IllegalStateException: "WorkManager is not initialized properly...") when
WorkManager.getInstance()is called even without any custom WorkManager configuration. It looks like a WorkManager timing issue.Those rare exceptions are gracefully handled with this fix. It's safe since event-dispatch service will be scheduled again on next events.
Test plan
Issues