Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ATS): add ODP API clients #440

Merged
merged 16 commits into from
Jan 3, 2023
Merged

feat(ATS): add ODP API clients #440

merged 16 commits into from
Jan 3, 2023

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Nov 29, 2022

Summary

Add ODP API clients for segment fetch and event dispatch:

  • DefaultODPAPIManager
  • ODPSegmentClient
  • ODPEventClient

Test plan

  • Unit tests

Issues

  • FSSDK-8546, FSSDK-8547

@jaeopt jaeopt requested a review from a team as a code owner November 29, 2022 23:14
@mnoman09 mnoman09 closed this Dec 9, 2022
@mnoman09 mnoman09 reopened this Dec 9, 2022
@jaeopt jaeopt closed this Dec 14, 2022
@jaeopt jaeopt reopened this Dec 14, 2022
@jaeopt jaeopt closed this Dec 15, 2022
@jaeopt jaeopt reopened this Dec 15, 2022
@jaeopt jaeopt closed this Dec 16, 2022
@jaeopt jaeopt reopened this Dec 16, 2022
@jaeopt jaeopt closed this Dec 16, 2022
@jaeopt jaeopt reopened this Dec 16, 2022
@jaeopt jaeopt removed their assignment Dec 16, 2022
mnoman09
mnoman09 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@mnoman09 mnoman09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation looks good. Just have one question that is the final and complete implementation of ODP in android SDK? Or will there be a separate PR in which, we will expose the sendODPEvent and registration of ODP manager functions?

@jaeopt
Copy link
Contributor Author

jaeopt commented Jan 3, 2023

This implementation looks good. Just have one question that is the final and complete implementation of ODP in android SDK? Or will there be a separate PR in which, we will expose the sendODPEvent and registration of ODP manager functions?
@mnoman09 there will be one more PR for top-level integration as you expect.

@jaeopt jaeopt merged commit ceab50f into master Jan 3, 2023
@jaeopt jaeopt deleted the jae/odp-client branch January 3, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnoman09 mnoman09 mnoman09 approved these changes

Assignees
No one assigned
Labels
🤖 24 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeopt @mnoman09 @optimizely-codereview-bot