Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix servo run_servo being called twice preventing clean shutdown #562

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix servo run_servo being called twice preventing clean shutdown #562

merged 2 commits into from
Dec 13, 2023

Conversation

linkous8
Copy link
Contributor

  • bump virtualenv to fix local runs of pre-commit

@linkous8 linkous8 merged commit f81d589 into main Dec 13, 2023
@linkous8 linkous8 deleted the OPTSERV-1079-servo-stop-leaves-co-in-unrecoverable-state branch December 13, 2023 21:32
pavel-georgiev
pavel-georgiev reviewed Dec 13, 2023
View reviewed changes
Copy link

@pavel-georgiev pavel-georgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround. Can you please test before/after the change to make sure that the behavior described in the bug report is observable before the change and is fixed after the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-georgiev pavel-georgiev pavel-georgiev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linkous8 @pavel-georgiev