Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danielh/eng 785 run mypy on servox #402

Merged
merged 20 commits into from
Apr 2, 2022

Conversation

DanielHHowell
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Feb 8, 2022

Copy link
Contributor

@linkous8 linkous8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LTGM to me, I doubt we will get the tests green until after the upcoming architectural refactor (so will leave them optional for now)

@linkous8 linkous8 self-requested a review April 1, 2022 15:37
@DanielHHowell DanielHHowell merged commit ce35492 into main Apr 2, 2022
@DanielHHowell DanielHHowell deleted the danielh/eng-785-run-mypy-on-servox branch April 2, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants