Add container logs to restart count error messages #383
Conversation
- Add types module for kubernetes - Implement new Pod method get_logs_for_container_statuses - Add include_container_logs param to raise_for_status methods - Include container logs in rejection messages for restart counts ( implementation for other failures TBD) - Introduce container_logs_in_error_status flag to kubernetes config
ENG-726 Servox should include logs for crashed containers in its error messages
When TeaStore environment variable injection is misconfigured, the JVM will fail to start on settings that may otherwise be valid. By including container logs in the rejection messages, we will be able to tell if this is the case at a glance |
method - Also add group to logs of kube_metrics permission check failures
- Add timeouts to prometheus kubetest wait for manifests
logs for unready containers
get error handling
data structure
|
Looks immaculate as usual. As far as test coverage I presume there is good testing for the underlying functionality it's modifying or any additional testing would be kind of byzantine integration tests? Are any unit tests warranted? |
Unit tests to be added in a later update. Thus far, it has been pen tested and is disabled by default so poses minimal risk of disruption |
implementation for other failures TBD)