Set kubernetes_asyncio back to official package #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update pyproject.toml and poetry.lock - Add k8s connector missing explicit imports, alphabetize - Update KubernetesModel.api_client context manager with default_headers argument - Set default_header content-type = application/merge-patch+json for rollout patch method
ENG-646 Set kubernetes connector kubernetes_asyncio source back to the official library
An ideal workaround has been found that eliminates the need for the forked kubernetes asyncio github repo and pypi project. The branch/PR associated with this ticket sets the kubernetes_asyncio dependency back to the official repo and applies the workaround (more info on said workaround below) The fix is to use the undocumented |
DanielHHowell
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argument
rollout patch method