Fred/eng 212 implement fast fail support in the prometheus connector #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
linkous8
commented
Aug 30, 2021
- Update api Status.from_error to handle aborted status
- Define configuration for fast-fail functionality
- Define EventAbortedError error to support aborted status
- Implement generic fast-fail observer for use in connectors
- Define models for SLO checking and add to userdata parsing
- Implement fast-fail support in the prometheus connector
- Add unit tests for FastFailObserver
- Add integration test for fast fail under prometheus connector
- Update api Status.from_error to handle aborted status - Define configuration for fast-fail functionality - Define EventAbortedError error to support aborted status - Implement generic fast-fail observer for use in connectors - Define models for SLO checking and add to userdata parsing - Implement fast-fail support in the prometheus connector - Add unit tests for FastFailObserver - Add integration test for fast fail under prometheus connector
ENG-212 Implement fast-fail support in the prometheus connector of Servox
The first pass implementation will be based off the current state of the design doc specified in ENG-55 and will be iterated on as needed in order to maintain velocity for the release of Dev 2.4 https://opsani.slab.com/posts/2021-06-fast-fail-support-g2e90h87 |
rstarmer
approved these changes
Sep 2, 2021
DanielHHowell
approved these changes
Sep 2, 2021
- remove allow_equals condition config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.