modify on_error:destroy behavior for deployments #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connectors/kubernetes.py: a deployment handled by the connector is 'foreign' (not created by the connector), the connector cannot auto-restore it if it has been deleted. Therefore, it should not delete its deployment-under-control when the on_error setting is configured to 'destroy' (which is actually intended as 'destroy and re-create on the next adjust'). This patch modifies the connector to set replicas=0, instead - consistent with the behavior of the servoX predecessor (servo-k8s).
ENG-257 ServoX/kubernetes: modify on_failure: destroy behavior for deployments
when working with a deployment (that isn't created by ServoX/kubernetes), the 'on_failure: destroy' behavior should be modified to match the old servo-k8s, namely: scale the deployment to 0 instances (thus destroying all pods). This proposed change should not affect the 'canary mode' behavior - in this mode, the kubernetes connector itself creates the canary pod and it can (and should) destroy it when a n adjust failure occurs. |
blakewatters
suggested changes
Aug 23, 2021
- rename 'destroy' config option to 'shutdown' - modify tests to match - fix method comment
linkous8
approved these changes
Aug 30, 2021
linkous8
suggested changes
Aug 31, 2021
There was a problem hiding this comment.
Please add requested unit test.
Also probably worth resolving the the open items from the last review although I will leave those to your discretion
https://github.com/opsani/servox/pull/317/files#r698604812
https://github.com/opsani/servox/pull/317/files#r698605379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectors/kubernetes.py: a deployment handled by the connector is
'foreign' (not created by the connector), the connector cannot
auto-restore it if it has been deleted. Therefore, it should not delete
its deployment-under-control when the on_error setting is configured to
'destroy' (which is actually intended as 'destroy and re-create on the next
adjust').
This patch modifies the connector to set replicas=0, instead -
consistent with the behavior of the servoX predecessor (servo-k8s).
(Linear task: https://linear.app/opsani/issue/ENG-257/servoxkubernetes-modify-on-failure-destroy-behavior-for-deployments)