-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KarafDistributionOption.systemBundle #53
Open
Flamenco
wants to merge
3
commits into
ops4j:master
Choose a base branch
from
Flamenco:feature_system_bundle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
127 changes: 127 additions & 0 deletions
127
...am-container-karaf/src/main/java/org/ops4j/pax/exam/karaf/options/SystemBundleOption.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,127 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.ops4j.pax.exam.karaf.options; | ||
|
||
import java.io.File; | ||
import java.net.MalformedURLException; | ||
|
||
import org.ops4j.pax.exam.Option; | ||
import org.ops4j.pax.exam.options.MavenArtifactUrlReference; | ||
import org.ops4j.pax.exam.options.RawUrlReference; | ||
import org.ops4j.pax.exam.options.UrlReference; | ||
|
||
/** | ||
* Copies the specified file into the Karaf system folder. (A Karaf folder that follows the m2 | ||
* directory structure). The artifact will also be added to the startup.properties | ||
*/ | ||
public class SystemBundleOption implements Option { | ||
|
||
private String group; | ||
private String artifact; | ||
private String version; | ||
private File file; | ||
|
||
/** | ||
* Installs the specified artifact into the Karaf system folder and adds an entry to | ||
* startup.properties | ||
* | ||
* @see SystemBundleOption | ||
*/ | ||
public SystemBundleOption(String aGroup, String artifact, String version, File file) { | ||
addSystemBundle(aGroup, artifact, version, file); | ||
} | ||
|
||
/** | ||
* Installs the specified artifact into the Karaf system folder and adds an entry to | ||
* startup.properties | ||
* | ||
* @see SystemBundleOption | ||
*/ | ||
public SystemBundleOption(String aGroup, String artifact, String version) { | ||
addSystemBundle(aGroup, artifact, version); | ||
} | ||
|
||
/** | ||
* @return The Maven group ID | ||
*/ | ||
public String getGroup() { | ||
return group; | ||
} | ||
|
||
/** | ||
* @return The Maven artifact ID | ||
*/ | ||
public String getArtifact() { | ||
return artifact; | ||
} | ||
|
||
/** | ||
* @return The Maven version ID | ||
*/ | ||
public String getVersion() { | ||
return version; | ||
} | ||
|
||
private SystemBundleOption addSystemBundle(String aGroup, String artifact, String version) { | ||
return addSystemBundle(aGroup, artifact, version, null); | ||
} | ||
|
||
private SystemBundleOption addSystemBundle(String aGroup, String artifact, String version, | ||
File file) { | ||
this.group = aGroup; | ||
this.artifact = artifact; | ||
this.version = version; | ||
this.file = file; | ||
return this; | ||
} | ||
|
||
/** | ||
* @return The URL to fetch the artifact | ||
*/ | ||
public UrlReference getLibraryUrl() { | ||
if (file != null) { | ||
try { | ||
return new RawUrlReference(file.toURI().toURL().toString()); | ||
} | ||
catch (MalformedURLException e) { | ||
e.printStackTrace(); | ||
return null; | ||
} | ||
} | ||
else { | ||
return new MavenArtifactUrlReference().groupId(group).artifactId(artifact) | ||
.version(version); | ||
} | ||
} | ||
|
||
/** | ||
* @return The maven repository path to the artifact. Must start with <strong>/</strong>. This | ||
* path should not include the /system prefix. | ||
*/ | ||
public String getRepositoryPath() { | ||
String path = "/" + getGroup().replace(".", "/"); | ||
path += "/" + getArtifact(); | ||
path += "/" + getVersion(); | ||
if (file != null) { | ||
path += "/" + file.getName(); | ||
} | ||
else { | ||
path += "/" + getArtifact() + "-" + getVersion() + ".jar"; | ||
} | ||
return path; | ||
} | ||
} |
59 changes: 59 additions & 0 deletions
59
...tainer-karaf/src/test/java/org/ops4j/pax/exam/karaf/container/SystemBundleOptionTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/* | ||
* Copyright (C) 2011 Harald Wellmann | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.ops4j.pax.exam.karaf.container; | ||
|
||
import static org.hamcrest.core.Is.is; | ||
import static org.hamcrest.core.IsNull.notNullValue; | ||
import static org.junit.Assert.assertThat; | ||
|
||
import java.util.ArrayList; | ||
import java.util.Arrays; | ||
|
||
import javax.inject.Inject; | ||
|
||
import org.junit.Test; | ||
import org.junit.runner.RunWith; | ||
import org.ops4j.pax.exam.Configuration; | ||
import org.ops4j.pax.exam.Option; | ||
import org.ops4j.pax.exam.junit.PaxExam; | ||
import org.ops4j.pax.exam.karaf.options.KarafDistributionOption; | ||
import org.ops4j.pax.exam.spi.reactors.ExamReactorStrategy; | ||
import org.ops4j.pax.exam.spi.reactors.PerMethod; | ||
import org.ops4j.pax.swissbox.tracker.ServiceLookup; | ||
import org.osgi.framework.BundleContext; | ||
|
||
@RunWith(PaxExam.class) | ||
@ExamReactorStrategy(PerMethod.class) | ||
public class SystemBundleOptionTest extends KarafTestContainerITest { | ||
|
||
@Inject | ||
BundleContext bc; | ||
|
||
@Configuration | ||
public Option[] config() { | ||
ArrayList<Option> opts = new ArrayList<>(Arrays.asList(super.config())); | ||
opts.add(KarafDistributionOption.systemBundle("org.ops4j.pax.exam", "regression-pde-bundle", | ||
"2.3.0")); | ||
return opts.toArray(new Option[0]); | ||
} | ||
|
||
@Test | ||
public void getService() { | ||
Object service = ServiceLookup.getService(bc, | ||
"org.ops4j.pax.exam.regression.pde.HelloService"); | ||
assertThat(service, is(notNullValue())); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Javadoc to all public classes.