Move wip checks to github actions #276
Conversation
actions/src/dispatcher.js
Outdated
| case constants.wipCheck: | ||
| await wipDraftModule.checkWIP(); |
There was a problem hiding this comment.
| case constants.wipCheck: | |
| await wipDraftModule.checkWIP(); | |
| case constants.wipCheck: | |
| core.info('wip check triggerred'); | |
| await wipDraftModule.checkWIP(); |
can we have something like this? This is to make debugging easier and also we'll know what was executed in the action.
|
Hi @jameesjohn. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
actions/src/utils.js
Outdated
| * @param {string[]} assignees | ||
| * @param {string} comment | ||
| */ | ||
| const pingAndAssignUsers = async (octokit, pullRequest, assignees, comment) => { |
There was a problem hiding this comment.
This function doesn't really ping users, it just creates comment (which might contain entirely different content).
There was a problem hiding this comment.
Yes, but it also assigns the users. Comments can be created directly. This function helps when we want to make the comment and also assign users at the same time.
Co-authored-by: Vojtěch Jelínek <vojtin.j@gmail.com>
Co-authored-by: Vojtěch Jelínek <vojtin.j@gmail.com>
|
PTAL @vojtechjelinek |
|
Hi @jameesjohn. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
Explanation
Moves WIP/Draft checks to github actions
These features have been tested at jameesjohn/comment-on-pr#51 (comment)
Checklist