Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instruction to remove PRIVATE KEY from README #251

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

Naman-1234
Copy link
Contributor

Explanation

Users or contributors have to remove PRIVATE KEY from Readme.md in order to use Oppiabot Locally Since PRIVATE KEY gets automatically detected by .pem file. But this gets overlooked since it is mentioned in one of the various comments in .env file. I personally faced this difficulty and also seen some of the other contributors facing the same. I asked it on the Gitter and took more than 1 day to resolve this. This might not be a big addition but will definitely prove helpful to new contributors.

Checklist

  • I have successfully deployed my own instance of Oppiabot.
    • You can find instructions for doing this here.
  • [] I have manually tested all the changes made in this PR following the manual tests matrix.

@Naman-1234
Copy link
Contributor Author

@vojtechjelinek and @jameesjohn Sir, Please review this PR. Thanks.

@Naman-1234 Naman-1234 changed the title Added an Important Instruction in Readme Added instruction to remove PRIVATE KEY from README Apr 7, 2021
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vojtechjelinek vojtechjelinek merged commit e053814 into oppia:master Apr 7, 2021
@Naman-1234 Naman-1234 deleted the contributing branch April 7, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants