-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #164: Replace Showtim3 with DubeySandeep #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, just a two nits.
userWhitelist.json
Outdated
@@ -22,10 +22,12 @@ | |||
"aks681" | |||
], | |||
"teamLeads": { | |||
"onboardingTeam": "Showtim3", | |||
"onboardingTeam": "DubeySandeep", | |||
"releaseTeam": "ankita240796", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now me and Nithesh but I guess you can add just me for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhmm this means that oppiabot will ping you for good first issues since we are currently pinging the onboarding team lead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to replace Ankita with me, and keep DubeySandeep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay.
@@ -13,7 +13,7 @@ | |||
"kevintab95", | |||
"seanlip", | |||
"ankita240796", | |||
"Showtim3", | |||
"DubeySandeep", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also add Srijan Redy to this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Explanation
Fixes #164: Replaces all mentions of Showtim3 with DubeySandeep.
Also, allow configuring users via userWhitelist.json.
Checklist