Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub Action for the "PR: don't merge…" labels #205

Closed
vojtechjelinek opened this issue Feb 23, 2021 · 4 comments · Fixed by #264
Closed

Add a GitHub Action for the "PR: don't merge…" labels #205

vojtechjelinek opened this issue Feb 23, 2021 · 4 comments · Fixed by #264
Assignees

Comments

@vojtechjelinek
Copy link
Contributor

Couldn't we add a GitHub actions check that fails on the presence of the "PR: don't merge…" labels & make it a required check?

I think we can listen for label changes, too, so that particular workflow re-runs if we did that, I'm pretty sure auto-merge would respect it since it has to match normal merging criteria (which for us is approvals + all required tests passing).

@vojtechjelinek
Copy link
Contributor Author

Hi @jameesjohn, do you think this would be possible to do? Do you see any problems that could arise from implementing this?

@jameesjohn
Copy link
Contributor

Yes, this is very possible to achieve. I'm not sure of any problems that could arise from this, but do you think the action should be written in oppiabot GitHub actions or in the main oppia repo?

@vojtechjelinek
Copy link
Contributor Author

I guess similar to the action that is used to checking issue labels.

@jameesjohn
Copy link
Contributor

Right, okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants