-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a GitHub Action for the "PR: don't merge…" labels #205
Comments
Hi @jameesjohn, do you think this would be possible to do? Do you see any problems that could arise from implementing this? |
Yes, this is very possible to achieve. I'm not sure of any problems that could arise from this, but do you think the action should be written in oppiabot GitHub actions or in the main oppia repo? |
I guess similar to the action that is used to checking issue labels. |
Right, okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Couldn't we add a GitHub actions check that fails on the presence of the "PR: don't merge…" labels & make it a required check?
I think we can listen for label changes, too, so that particular workflow re-runs if we did that, I'm pretty sure auto-merge would respect it since it has to match normal merging criteria (which for us is approvals + all required tests passing).
The text was updated successfully, but these errors were encountered: