Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight refactor #49

Merged
merged 6 commits into from
Jan 9, 2023
Merged

Slight refactor #49

merged 6 commits into from
Jan 9, 2023

Conversation

PWAlessi
Copy link

@PWAlessi PWAlessi commented Jan 9, 2023

Slight refactor to unit tests

@PWAlessi PWAlessi requested a review from a team as a code owner January 9, 2023 19:23
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #49 (e17e56a) into main (39f3692) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   82.44%   82.44%           
=======================================
  Files           3        3           
  Lines         490      490           
=======================================
  Hits          404      404           
  Misses         73       73           
  Partials       13       13           
Impacted Files Coverage Δ
frontend.go 89.26% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pwalessi-dell and others added 6 commits January 9, 2023 14:52
Signed-off-by: patrick-alessi <patrick.alessi@dell.com>
Signed-off-by: patrick-alessi <patrick.alessi@dell.com>
Signed-off-by: patrick-alessi <patrick.alessi@dell.com>
Signed-off-by: patrick-alessi <patrick.alessi@dell.com>
Signed-off-by: patrick-alessi <patrick.alessi@dell.com>
Signed-off-by: patrick-alessi <patrick.alessi@dell.com>
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, good fixes

@glimchb glimchb merged commit eab2fd4 into opiproject:main Jan 9, 2023
@PWAlessi PWAlessi deleted the test_refactor branch January 24, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants