-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security: Update README.md #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change looks great, just a few questions before we merge it:
- copy-paste of image from POC repo ?
- can we remove
security-spec.md
and left withreadme
only ?
This adds more information into the `security/README.md` file detailing what exactly the OPI Security APIs are currently targeting, and the proposed architecture around the IPsec portion of the APIs. I also collapsed the security-spec.md file into the README.md file. Signed-off-by: Kyle Mestery <mestery@mestery.com>
68c5bfd
to
c5df3c2
Compare
Signed-off-by: Kyle Mestery <mestery@mestery.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great now,
thanks for fixing my small nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm reserving endorsement of the approach proposed here.
But so far as this text documenting the approach goes, I'm happy.
Thanks for addressing my earlier review.
@shorman-corigine we are welcoming the reviews and other opinions... you can comment freely |
Of course :) |
I do think we need to separate reference implementation VS generic APIs... also storage in this repo doesn't talk about specific implementations storage readme |
This adds more information into the
security/README.md
file detailingwhat exactly the OPI Security APIs are currently targeting, and the
proposed architecture around the IPsec portion of the APIs.
Signed-off-by: Kyle Mestery mestery@mestery.com