add upstream NFD Operator

[ArangoGutierrez]

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

Thanks submitting your Operator. Please check below list before you create your Pull Request.

---

Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.

---

New Submissions

• Does your operator have nested directory structure?
• Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
• Are you familiar with our contribution guidelines?
• Have you packaged and deployed your Operator for Operator Framework?
• Have you tested your Operator with all Custom Resource Definitions?
• Have you tested your Operator in all supported installation modes?
• Is your submission signed?

Updates to existing Operators

• Is your new CSV pointing to the previous version with the replaces property?
• Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
• Have you tested an update to your Operator when deployed via OLM?
• Is your submission signed?

Your submission should not

• Modify more than one operator
• Modify an Operator you don't own
• Rename an operator - please remove and add with a different name instead
• Submit operators to both upstream-community-operators and community-operators at once
• Modify any files outside the above mentioned folders
• Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

1. Description about the managed Application and where to find more information
2. Features and capabilities of your Operator and how to use it
3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

• Human readable name and 1-liner description about your Operator
• Valid category name¹
• One of the pre-defined capability levels²
• Links to the maintainer, source code and documentation
• Example templates for all Custom Resource Definitions intended to be used
• A quadratic logo

Remember that you can preview your CSV here.

--

¹ If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

² For more information see here

[mvalahtv]

@ArangoGutierrez Can you please check for error

Error from server (NotFound): subscriptions.operators.coreos.com "nfd-sub" not found
FAIL: Failed to reach AtLatestKnown subscription status for "nfd-sub"
Error from server (NotFound): subscriptions.operators.coreos.com "nfd-sub" not found
Error from server (NotFound): subscriptions.operators.coreos.com "nfd-sub" not found
installplan status for "":
error: arguments in resource/name form must have a single resource and name
    Checking if subscriptions passes              [  FAILED  ]
make: *** [Makefile:80: operator.install] Error 1
Makefile:46: recipe for target 'operator.install' failed
make: *** [operator.install] Error 2

[mvalahtv]

@ArangoGutierrez any updates? Is this PR still valid?

[ArangoGutierrez]

@mvalahtv I did added some changes, but I don't understand the current ERROR, would appreciate some guidance from you

[mvalahtv]

I am rerunning tests now. Let's see. If this will fail. I would recommend you to rebese to latest master. We are using more resent version of k8s in the test

[ArangoGutierrez]

Thanks for the tip @mvalahtv , rebased, hope the CI gives me green light this time

[mvalahtv]

In my local kind cluster i see

Events:
  Type     Reason     Age                    From                                  Message
  ----     ------     ----                   ----                                  -------
  Normal   Scheduled  4m                     default-scheduler                     Successfully assigned test-operators/nfd-operator-5cd67c674b-rq2cw to operator-test-control-plane
  Normal   Pulled     2m59s (x4 over 3m44s)  kubelet, operator-test-control-plane  Successfully pulled image "quay.io/kubernetes_incubator/node-feature-discovery-operator:latest"
  Normal   Created    2m59s (x4 over 3m41s)  kubelet, operator-test-control-plane  Created container nfd-operator
  Warning  Failed     2m59s (x4 over 3m41s)  kubelet, operator-test-control-plane  Error: failed to create containerd task: OCI runtime create failed: container_linux.go:349: starting container process caused "exec: \"cluster-nfd-operator\": executable file not found in $PATH": unknown
  Warning  BackOff    2m22s (x8 over 3m39s)  kubelet, operator-test-control-plane  Back-off restarting failed container
  Normal   Pulling    2m9s (x5 over 3m59s)   kubelet, operator-test-control-plane  Pulling image "quay.io/kubernetes_incubator/node-feature-discovery-operator:latest"

[ArangoGutierrez]

Thanks a lot @mvalahtv , yeah that was on me, the downstream operator has a diff bin name on the dockerfile

[mvalahtv]

Your latest commit is fine for me, when tested locally.

[ArangoGutierrez]

Yeah is just that Travis doesn't love me :(

[ArangoGutierrez]

{"level":"info","ts":1594903498.6237082,"logger":"cmd","msg":"Go Version: go1.13.4"}

{"level":"info","ts":1594903498.6237419,"logger":"cmd","msg":"Go OS/Arch: linux/amd64"}

{"level":"info","ts":1594903498.6237526,"logger":"cmd","msg":"Version of operator-sdk: v0.4.0+git"}

{"level":"info","ts":1594903498.6241062,"logger":"leader","msg":"Trying to become the leader."}

{"level":"info","ts":1594903498.6550577,"logger":"leader","msg":"No pre-existing lock was found."}

{"level":"info","ts":1594903498.6595385,"logger":"leader","msg":"Became the leader."}

{"level":"info","ts":1594903499.1204014,"logger":"controller-runtime.metrics","msg":"metrics server is starting to listen","addr":":8080"}

{"level":"info","ts":1594903499.1207275,"logger":"cmd","msg":"Registering Components."}

{"level":"info","ts":1594903499.1210232,"logger":"cmd","msg":"Starting the Cmd."}

{"level":"info","ts":1594903499.1212506,"logger":"controller-runtime.manager","msg":"starting metrics server","path":"/metrics"}

{"level":"info","ts":1594903499.1213593,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"nodefeaturediscovery-controller","source":"kind source: /, Kind="}

{"level":"info","ts":1594903499.1216223,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"nodefeaturediscovery-controller","source":"kind source: /, Kind="}

{"level":"info","ts":1594903499.1217177,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"nodefeaturediscovery-controller","source":"kind source: /, Kind="}

{"level":"info","ts":1594903499.1218169,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"nodefeaturediscovery-controller","source":"kind source: /, Kind="}

{"level":"info","ts":1594903499.121916,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"nodefeaturediscovery-controller","source":"kind source: /, Kind="}

{"level":"info","ts":1594903499.1220045,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"nodefeaturediscovery-controller","source":"kind source: /, Kind="}

{"level":"info","ts":1594903499.1221583,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"nodefeaturediscovery-controller","source":"kind source: /, Kind="}

{"level":"info","ts":1594903499.1222415,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"nodefeaturediscovery-controller","source":"kind source: /, Kind="}

{"level":"info","ts":1594903499.222791,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"nodefeaturediscovery-controller","source":"kind source: /, Kind="}

{"level":"info","ts":1594903499.3234627,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"nodefeaturediscovery-controller","source":"kind source: /, Kind="}

{"level":"info","ts":1594903499.4240537,"logger":"controller-runtime.controller","msg":"Starting Controller","controller":"nodefeaturediscovery-controller"}

{"level":"info","ts":1594903499.424191,"logger":"controller-runtime.controller","msg":"Starting workers","controller":"nodefeaturediscovery-controller","worker count":1}

From the logs it looks like the operator is kicking in, but travis still fails :(

[ArangoGutierrez]

@mvalahtv I am clueless on how to fix travis at-this-point :( , happy to follow any guidance you and your team could give me.

[mvalahtv]

/test CVP

[openshift-ci-robot]

@mvalahtv: No presubmit jobs available for operator-framework/community-operators@master

In response to this:

/test CVP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mvalahtv]

I am retesting it.

[ArangoGutierrez]

I really don't understand why travis is failing :(

[ArangoGutierrez]

@mvalahtv does travis setup has some sort of timeout or something? the logs show that the operator is working, but then fails with no error message
🤷

[ArangoGutierrez]

PING

[mvalahtv]

@ArangoGutierrez can you please rebase to the latest master. We have more tests there and they can point us to correct direction. Sorry for late reply

[ArangoGutierrez]

@mvalahtv rebased! thanks for the help! a lot!

[mvalahtv]

Our new tests passed, but the old one didn't pass. On Monday i will dig more in to this problem.

[ArangoGutierrez]

Best monday morning news ever!!!!