Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update ODH Dashboard downstream to latest #151

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

tumido
Copy link
Member

@tumido tumido commented Jan 22, 2021

@sesheta sesheta requested review from 4n4nd and HumairAK January 22, 2021 18:07
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2021
@sesheta
Copy link
Member

sesheta commented Jan 22, 2021

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/adrienverge/yamllint.git.
[INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/adrienverge/yamllint.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Passed
Check for merge conflicts................................................Passed
Fix End of Files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing odh/overlays/moc/monitoring/dashboards/operate-first/argocd.yaml

Check for added large files..............................................Passed
Check for case conflicts.................................................Passed
Check JSON...........................................(no files to check)Skipped
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
yamllint.................................................................Passed

@tumido tumido force-pushed the update-dashboard-to-latest branch from 63efc4b to e738806 Compare January 29, 2021 14:07
@tumido tumido requested a review from anishasthana January 29, 2021 14:08
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
@anishasthana
Copy link
Member

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021
@HumairAK
Copy link
Member

/lgtm

@HumairAK
Copy link
Member

/approve

@sesheta
Copy link
Member

sesheta commented Jan 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@sesheta sesheta merged commit 88c7c1d into operate-first:master Jan 29, 2021
@tumido tumido deleted the update-dashboard-to-latest branch November 2, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants