Added resampling function to mosaic process. #85
Conversation
There was a problem hiding this comment.
Hi @hb6688 While I was testing your PR, I found some issues which is not compatible with the rest of the functions. Please see the comments.
| @@ -43,6 +43,10 @@ runconfig: | |||
| # - average : overlapped areas are averaged. | |||
| # - first : choose one burst without average. | |||
| mosaic_mode: 'first' | |||
| resamp_required: True | |||
| resamp_method: 'gdal.GRA_NearestNeighbour' | |||
There was a problem hiding this comment.
This can be simpler. For example, 'nearest', 'average', 'bilinear'...
src/dswx_sar/defaults/dswx_ni.yaml
Outdated
| @@ -70,7 +70,7 @@ runconfig: | |||
| mgrs_collection_database_file: | |||
|
|
|||
| primary_executable: | |||
| product_type: DSWX_NI | |||
| product_type: dswx_ni | |||
There was a problem hiding this comment.
I'm not sure why you are trying to change this? To have consistency with the DSWx-S1, I think we should keep as it is.(
)
src/dswx_sar/mosaic_gcov_frame.py
Outdated
| @@ -756,13 +867,16 @@ def run(cfg): | |||
| # Mosaic input RTC into output Geotiff | |||
| reader.process_rtc_hdf5( | |||
| input_list, | |||
| scratch_dir, | |||
| output_dir, | |||
There was a problem hiding this comment.
I think this line is not what we want to do. The mosaic geotiff should be the scratch directory. The output dir will be used only for saving the final (water) products. Please refer to the PR I submitted to your repo.
There was a problem hiding this comment.
@oberonia78 I think I will remove all 'output_dir'.
Updated the following scripts:
Added following parameters to schema and yaml:
resamp_required: bool(required=False)
resamp_method: str(required=False)
resamp_out_res_x: num(required=False)
resamp_out_res_y: num(required=False)