Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dswx ni beta point #110

Merged
merged 12 commits into from
Oct 25, 2024
Merged

Conversation

hb6688
Copy link
Contributor

@hb6688 hb6688 commented Oct 13, 2024

Interface to detect operation mode for input NISAR RTC.

@hb6688 hb6688 requested a review from oberonia78 October 13, 2024 18:49
Copy link
Contributor Author

@hb6688 hb6688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the updates from Jungkyo, LGTM.

@@ -63,7 +63,7 @@ Then, from inside the cloned repository, build the Docker image:
Load the Docker container image onto your computer:

```bash
docker load -i docker/dockerimg_dswx_s1_final_1.0.tar
docker load -i docker/dockerimg_dswx_s1_final_patch_1.1.tar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove README.md in your PR.

@@ -1,7 +1,7 @@
#!/bin/bash

IMAGE=opera/dswx-s1
tag=final_1.0
tag=final_patch_1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove build_docker.sh

Copy link
Contributor

@oberonia78 oberonia78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oberonia78 oberonia78 merged commit af5c48a into opera-adt:dswx-ni-beta-point Oct 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants